fix: line endings are now respected on windows #260
Merged
+82
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0d39f6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jasekiw
force-pushed
the
fix-line-endings
branch
from
a953456 to
3b5e991
Compare
Andarist
reviewed
Aug 8, 2025
Andarist
reviewed
Aug 8, 2025
Co-authored-by: Mateusz Burzyński <[email protected]>
jasekiw
force-pushed
the
fix-line-endings
branch
from
05fa860 to
18f2fee
Compare
|
@Andarist Does everything look good now that I've added tests? |
|
@Andarist just a reminder - I made all the requested changes 😄 |
Andarist
reviewed
Aug 28, 2025
Andarist
reviewed
Aug 28, 2025
Merged
|
I'm sorry, I missed the previous notification ;p I was not holding this PR a hostage, I swear! I appreciate you paying the ransom though /j 😉 |
|
😆 I saw the projects you work on felt inclined to give something. I miss 99% of my GitHub notifications so I understand! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows all the package.json files would get their line endings changed to lf. This would cause all the package.json files to be marked as modified. This pr fixes the issue by detecting the line endings of the package.json file and normalizes them back what they originally were
Closes #257