fix(export): resolve frontmatter table styling and parsing in HTML an…#114
Closed
ThisIs-Developer wants to merge 3 commits into
Closed
fix(export): resolve frontmatter table styling and parsing in HTML an…#114ThisIs-Developer wants to merge 3 commits into
ThisIs-Developer wants to merge 3 commits into
Conversation
…d PDF exports for web and desktop app
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR improves YAML frontmatter handling in exports by ensuring frontmatter is parsed and rendered as a table for PDF export, and by enhancing the exported HTML’s inline styling so frontmatter tables/tags render consistently across light/dark themes in both the web and desktop builds.
Changes:
- Enhanced exported HTML inline CSS for
.frontmatter-table, plus added.fm-tagand.fm-complexstyling (web + desktop export templates). - Updated PDF export flow to parse YAML frontmatter and prepend the rendered frontmatter table before generating the PDF (web + desktop).
- Refreshed some desktop resource assets (CSS tweaks, modal attributes, etc.).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| script.js | Updates exported HTML inline frontmatter styling and prepends rendered frontmatter table during PDF export generation. |
| desktop-app/resources/styles.css | Tweaks mobile menu overlay behavior and tab border styling in desktop resources. |
| desktop-app/resources/js/script.js | Mirrors the web export changes for frontmatter styling/parsing in desktop build output (plus small related updates). |
| desktop-app/resources/index.html | Adds aria-hidden defaults to several desktop modals (but see comment about Mermaid zoom modal). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| <!-- Mermaid Zoom Modal --> | ||
| <div id="mermaid-zoom-modal" role="dialog" aria-modal="true" aria-label="Diagram zoom view"> | ||
| <div id="mermaid-zoom-modal" role="dialog" aria-modal="true" aria-label="Diagram zoom view" aria-hidden="true"> |
…document while preventing horizontal rule collisions
Deploying markdown-viewer with
|
| Latest commit: |
17a795f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ad8ff958.markdown-viewer.pages.dev |
| Branch Preview URL: | https://fix-frontmatter-export-styli.markdown-viewer.pages.dev |
Deploying markdownviewer with
|
| Latest commit: |
17a795f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c0e38e14.markdownviewer.pages.dev |
| Branch Preview URL: | https://fix-frontmatter-export-styli.markdownviewer.pages.dev |
…PDF exports while maintaining strict first-line standards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses YAML Frontmatter parsing and styling issues in both the web and desktop app versions for both HTML and PDF exports.
Changes Included
HTML Export Styling (Web & Desktop):
.fm-tagin the inline styles of exported HTML documents so tags/lists render as pill tags matching the main viewer interface's light and dark themes..fm-complexto properly style nested JSON/YAML objects in monospace blocks..frontmatter-tablerules (vertical alignments, text alignments, borders, and background zebra-striping).PDF Export Parsing (Web & Desktop):
exportPdflistener to run the frontmatter parser (parseFrontmatter) and render the frontmatter table (renderFrontmatterTable()), prepending it to the document body prior to PDF generation.Desktop App Build Assets: