jetstream: fix test_race failures#18
Open
AlexCuse wants to merge 5 commits intoThreeDotsLabs:masterfrom
Open
Conversation
Collaborator
Author
|
Note this fails almost every time in CI but not as often on my relatively powerful laptop. It is also rare that it fails on first run at all on the laptop, almost makes me wonder if repeated test runs are putting enough stress on the local broker / docker itself to create instability in the client. Hopefully we can find a reasonable synchronization solution between the two points but I thought the channel should be it :) |
3679169 to
247f3ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are seeing test_race failures intermittently with the jetstream package (more frequently in slower environments).
Example race detector output:
It seems like we are getting a callback delivered too late from the nats.go client, and in a way that existing synchronization code in the message handler doesn't catch. Test with updated nats.go client once a fix for nats-io/nats.go#1470 is available in case that helps.