Feature/added stream detail interface#27
Open
benjfield wants to merge 5 commits intoThreeDotsLabs:masterfrom
Open
Feature/added stream detail interface#27benjfield wants to merge 5 commits intoThreeDotsLabs:masterfrom
benjfield wants to merge 5 commits intoThreeDotsLabs:masterfrom
Conversation
benjfield
force-pushed
the
feature/added_stream_detail_interface
branch
from
46b7001 to
da38d4a
Compare
added 2 commits
November 19, 2024 16:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have replaced SubjectCalculator with an interface that can be implemented where needed.
This allows us to have additional stream based configuration (AllowRollup has been added initially) as well as initialisation outside of the publish hot path. A default subject generator in the form STREAM.TOPIC has been added, which allows for wildcarding, although this can easily be added to/replaced.
I have also added a wrapper for the previous subjectCalculator which allows for backwards compatibility.
Please let me know if you would like me to remove the basic dev container config for vscode - I will add it to the gitignore.