Skip to content

Conversation

ahkui
Copy link

@ahkui ahkui commented May 26, 2025

Signed-off-by: ahkui [email protected]

#574

Motivation / Background

Implement metrics collection using the OpenTelemetry MeterProvider

Detail

Implement metrics collection using the OpenTelemetry MeterProvider

Alternative approaches considered (if applicable)

Checklist

The resources of our team are limited. There are a couple of things that you can do to help us merge your PR faster:

  • I wrote tests for the changes.
  • All tests are passing.
    • If you are testing a Pub/Sub, you can start Docker with make up.
    • You can start with make test_short for a quick check.
    • If you want to run all tests, use make test.
  • Code has no breaking changes.
  • (If applicable) documentation on watermill.io is updated.

@ahkui ahkui force-pushed the metrics/opentelemetry branch from a1f41a2 to 5470970 Compare May 26, 2025 16:58
@ahkui
Copy link
Author

ahkui commented May 28, 2025

Hi @roblaszczak and @m110,

Could you please help review this PR when you have a moment?

Thanks!

@ahkui ahkui force-pushed the metrics/opentelemetry branch from 4182b09 to c51f8a9 Compare June 3, 2025 08:34
@roblaszczak
Copy link
Member

We had this issue with OpenTelemtry in many projects: open-telemetry/opentelemetry-go#4476

To avoid that it would be good to move OpenTelemetry implementation to a separate package, with a separate go.mod. So the main go.mod won't be affected.

I would moving those changes to a separate components/opentelemetry package.

Do you feel you'll have time for that @ahkui? Let us know!

@ahkui
Copy link
Author

ahkui commented Sep 18, 2025

We had this issue with OpenTelemtry in many projects: open-telemetry/opentelemetry-go#4476

To avoid that it would be good to move OpenTelemetry implementation to a separate package, with a separate go.mod. So the main go.mod won't be affected.

I would moving those changes to a separate components/opentelemetry package.

Do you feel you'll have time for that @ahkui? Let us know!

@roblaszczak yes, i can handle that

the new pkg i will move to components/metrics/opentelemetry, do you have other suggestion for the location ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants