#1739 #2177 OpenIddict authentication: role section, override scope and role key

[Eits-Ian]

Fixes #2177

• AllowedScopes feature is not functioning as anticipated during authentication with the OpenIddict server #2177

Proposed Changes

• Added role section
• Variable to define an override for the scope or role descriptor

"ScopeKey": "oi_scp" to enable OpenIddict

"RequiredRole": [ "User" ]

Successor

• #913 #1066 ScopesAuthorizer refactoring #1478

Closes #1739

• Cannot understand the AllowedScopes options #1739

[raman-m]

Hi @Eits-Ian !
Thanks for your interest in Ocelot gateway!

Please do the following:

• Merge PR 1
• Rebase feature branch onto develop
• Resolve all merge conflicts

[raman-m]

@Eits-Ian
I thought you needed a help to resolve the conflicts.
The feature branch has been rebased onto ThreeMammals:develop successfully!
Now we have 4 failed tests!
We cannot start code review till all tests have passed...

---

I see that develop branch in your fork is old.
Could you Sync fork please? So, the develop branch will be updated with all top commits!
Could you add me as collaborator to your forked repo please? I will update develop branch.

[raman-m]

4 failed tests!
Could you review & fix them please?

[Eits-Ian]

Sorry I did not get a chance to look at this till today, should be fixed, have added you as a collaborator, I hadn't looked at this for a couple of years. Need to add process policies, I am really busy at the moment so will not be able to get to this for a while.

[Eits-Ian]

The error is at ClaimsToDownstreamPathTests it is not authenticating, I need to take a look at what is happening but it will need to be later

[raman-m]

@Eits-Ian commented on Aug 24

Thanks for caring!
I am planning to help you in September by having of some pair programming...
Sorry, now I have a lot of things to do with this project...

[raman-m]

The branch has been rebased onto release/24.0 which has top commit 59b63ea !

• Further development is required❕
• Fixing failed tests is required❗

[raman-m]

@Eits-Ian Dear author,
Are you still with Ocelot?
And, what's your name? 😉

Will this PR close, is PR related to the following issues?

• Multiple values for single key in RouteClaimsRequirement #746
• Ocelot doesn't handle correctly RouteClaimsRequirement with a key as an Url #679
• Alternate array syntax to resolve : issue in key names for RouteClaimsRequirement option in configuration #1308

Please answer ASAP❗

P.S.

OpenIddict implementation, role section, override scope and role key

What is OpenIddict? It should likely not be part of the PR title; instead, the title should include Ocelot's artifact name or, if necessary, the ASP.NET one.

[Eits-Ian]

Raman, I need to go back and look at the code to see what I did but from memory, you could specify the roles/scopes but not use an authorization policy and it worked with openiddict. I haven't got much time to do much with this at the moment, I will need to get back into it as I must update the api, that use this, but that will not be for a few months. Best, Ian.

[raman-m]

I haven't got much time to do much with this at the moment, I will need to get back into it as I must update the api, that use this, but that will not be for a few months

It should be a matter of weeks, not months!

[Eits-Ian]

Raman, With all due respect I have a 3-year clinic project just about to open which I am a part owner of the clinic, and this is my priority, I'm not coding all day long. Best, Ian.

[raman-m]

@Eits-Ian
I don't understand you!
Should we close the PR or will you develop it in coming future?

[Eits-Ian]

Raman, As I said I do need to do it, but I will not be able to get to it for a few months, I currently end up losing days weeks to the clinic, then I get back to some coding but that is only a few hours at a time. In a few months the clinic will be open, and I will get back to this, I wish I had more time now, but I work 7 day weeks and all hours so there is just no more to give. Best, Ian.

[raman-m]

🆗 Got it! You are super busy… In this case, let me decide what to do with this PR…