Skip to content

#657 Ability to set UseDefaultCredentials per route #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

#657 Ability to set UseDefaultCredentials per route #1521

wants to merge 7 commits into from

Conversation

Sacrilege
Copy link

@Sacrilege Sacrilege commented Sep 22, 2021 •
edited by raman-m
Loading

Closes #657

Support setting WebClient.UseDefaultCredentials per route if needed.

Docs

This was referenced Sep 22, 2021
Closed
Open
@clintonbale
Copy link

Would be nice to get this merged in. Very useful PR.

@Sacrilege
Copy link
Author

Sacrilege commented Aug 8, 2022 •
edited
Loading

What will it take to get this merged in to main?
@TomPallister

stefancruz added a commit to stefancruz/Ocelot that referenced this pull request Dec 22, 2022
@stefancruz
Merge branch 'develop@Sacrilege' into develop
f16dc0b 
Cherry picked from ThreeMammals#1521
@raman-m
Copy link
Member

raman-m commented May 16, 2023

@Sacrilege Hi Troy!
Could you resolve merge conflicts please?
And what issue is this PR related to?

@raman-m raman-m added invalid Not actually an issue waiting Waiting for answer to question or feedback from issue raiser labels May 16, 2023
@raman-m raman-m marked this pull request as draft May 16, 2023 17:33
@raman-m raman-m marked this pull request as ready for review July 11, 2023 11:53
@raman-m raman-m added proposal Proposal for a new functionality in Ocelot and removed invalid Not actually an issue waiting Waiting for answer to question or feedback from issue raiser labels Jul 11, 2023
@raman-m raman-m self-requested a review July 11, 2023 11:57
@raman-m
Copy link
Member

raman-m commented Aug 28, 2023

The feature branch has been rebased onto ThreeMammals:develop successfully!
Welcome to code review!

@raman-m
Copy link
Member

raman-m commented Aug 28, 2023

@Sacrilege commented on Aug 8, 2022

I hope, merging will happen soon... 🤣

@raman-m raman-m changed the title added ability to set UseDefaultCredentials per route Ability to set UseDefaultCredentials per route Aug 28, 2023
@raman-m raman-m requested review from omdahl, Z-byte-prog, binarymash, jps, geffzhang and RaynaldM and removed request for Z-byte-prog and omdahl August 28, 2023 17:07
@raman-m raman-m force-pushed the develop branch 8 times, most recently from c216cdf to b458f0f Compare April 7, 2025 16:13
@raman-m raman-m force-pushed the develop branch 22 times, most recently from 908d84f to 0678e7a Compare April 19, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raman-m raman-m raman-m requested changes

@RaynaldM RaynaldM RaynaldM approved these changes

@Z-byte-prog Z-byte-prog Z-byte-prog approved these changes

@omdahl omdahl omdahl approved these changes

@ggnaegi ggnaegi Awaiting requested review from ggnaegi

Requested changes must be addressed to merge this pull request.

Assignees

@Sacrilege Sacrilege

@ggnaegi ggnaegi

Labels
feature A new feature high High priority proposal Proposal for a new functionality in Ocelot Spring'25 Spring 2025 release
Projects
None yet
Milestone
Spring'25
Development

Successfully merging this pull request may close these issues.

Ocelot not working with a Windows Authentication
9 participants
@Sacrilege @clintonbale @raman-m @pank789 @ggnaegi @tobiashoeft @RaynaldM @Z-byte-prog @omdahl