-
Notifications
You must be signed in to change notification settings - Fork 1.7k
#2080 Add new V8 params to fine-tune Polly's circuit-breaker behavior #2081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
#2080 Add new V8 params to fine-tune Polly's circuit-breaker behavior #2081
Conversation
Great! Which version are you planning to release it in? Please note that the PR depends on #2073, which needs to be merged before this PR. Therefore, this feature branch should be rebased after the merging of #2073, and ideally, after #2079 is merged as well. It appears that it won't be included in version 23.3, but rather in version 24.0, which is the next release following v23.3. |
Yes, @raman-m, you can add this when you want |
@RaynaldM |
@RaynaldM Conflicts! |
1de22fd
to
f69831a
Compare
Let's assign this to the Sep'24 milestone since the Annual 2023 milestone is already quite overloaded, and we need to reduce the scope of work for 2023. |
c216cdf
to
b458f0f
Compare
908d84f
to
0678e7a
Compare
Closes #2080
FailureRatio
andSamplingDuration
parameters of Polly V8 circuit-breaker #2080This PR adds 2 new parameters in
QoSOptions
to fine-tune circuit-breaker behavior 👉FailureRatio
: The failure-success ratio that will cause the circuit to break/open.SamplingDuration
: The time period over which the failure-success ratio is calculated (in seconds).