#930 Try to close WebSocket destination when state is Open or CloseReceived

[hogwartsdeveloper]

Fixes #930

• The WebSocket is in an invalid state (Aborted) for this operation. Valid states are: Open, CloseReceived #930

Proposed Changes

• error occurs when trying to close connections but destination status == abort

[raman-m]

Zhannur, thank you for the pull request!

Firstly, have you managed to reproduce the issue through tests?
I understand you've debugged the problem during runtime, but we need to verify the bug with tests.
Therefore, unit and acceptance tests are necessary before the team can proceed with a review.

P.S.

Please, update your develop branch in forked repo, and pay attention I've rebased the feature branch, so you need to re-checkout the branch locally.

[raman-m]

@hogwartsdeveloper FYI

• added authentication middleware for websockets in ocelot pipeline #720 with Websocket authentication token #718
• Websocket not propagating close event #674 with Suggested fix for #674 #998

[PaulARoy]

Hello, is this branch only missing tests to fix the bug? Can we contribute and if so, what would be the best way to do it? (Fork the branch on our side?)

[raman-m]

@PaulARoy Hi Paul!

Hello, is this branch only missing tests to fix the bug?

Yes, it is. The lack of tests breaches our Dev Process (refer to point 5). I cannot proceed with a code review without tests, as we cannot be certain that the bug fix is effective.

Can we contribute and if so, what would be the best way to do it? (Fork the branch on our side?)

The optimal approach is to pair-program with the author @hogwartsdeveloper to gain access to his forked repository. He will need to add you as a collaborator to his repository. If this is not feasible, please inform me again. We should wait a few weeks for him to add you as a collaborator.

[raman-m]

@hogwartsdeveloper Hello Zhannur!
Are you available? I requested that you write tests for this PR nearly three months ago.

Do you plan to complete your PR with tests?
If not, please add @PaulARoy as a collaborator to your forked repository here to assist with tests.

P.S. Your PRs have been moved to the September'24 milestone.

[cda963]

Any news on this?

[raman-m]

Hi @hogwartsdeveloper
When will you add tests, both unit and acceptance?

[coveralls]

coverage: 85.804% (+0.05%) from 85.75%
when pulling 98c11bb on hogwartsdeveloper:issues-930
into e78fe42 on ThreeMammals:develop.