Update lib360dataquality version and upgrade to Python 3.12 - #76
Merged
Conversation
…ip-tools This commit updates the lib360dataquality package in requirements.in so that it is not pinned to a specific commit but pulls the latest version. The net effect is that a number of packages have been updated to newer versions, including openpyxl which was causing issues in the datagetter compared to DQC due to different openpyxl versions. Also updated requirements_dev.in to add pip-tools so that requirements files can be compiled.
mrshll1001
approved these changes
Jul 27, 2026
mrshll1001
left a comment
mrshll1001
left a comment
There was a problem hiding this comment.
Happy with this; tested locally and datagetter ran with no issues, including with the problematic file in https://opendataservices.plan.io/issues/64991
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two main functional changes.
lib360dataquality, removing the pin to a specific commit, which introduces a number of package updates.Also,
pip-toolsis added to the developer requirements so that requirements files can easily be rebuilt.