Mw/new aggregate export data - #291
Merged
Merged
Conversation
michaelwood
force-pushed
the
mw/new-aggregate-export-data
branch
from
July 28, 2025 17:44
efdfdc0 to
abea717
Compare
michaelwood
force-pushed
the
mw/new-aggregate-export-data
branch
from
August 8, 2025 17:26
f129769 to
0de8150
Compare
michaelwood
force-pushed
the
mw/new-aggregate-export-data
branch
6 times, most recently
from
August 13, 2025 09:28
8f39e5c to
550ff2d
Compare
- Split the aggregate data into recipient individuals and organisations - Fix the avg calculation to use the total grants from the currency not the total of all grants - Mark the avg to be deprecated when no longer needed in public APIv1
- Run update_entities() to regenerate aggregate data - Add missing Orginfocache item to create a non-primary org id org - Update fixture file `manage.py dumpdata --natural-foreign --natural-primary > ./db/fixtures/test_data.json`
This ensures compatibility reflecting the structure change of aggregate data within the entities objects. The majority of the work is to combine the aggregate data back into not being split by recipient org/ind types.
This ensures that running the tests doesn't require being in a certain directory.
As the API will output valid json to a 404 it's helpful to see this in the output rather than just KeyError.
michaelwood
force-pushed
the
mw/new-aggregate-export-data
branch
from
August 13, 2025 16:37
70839b3 to
0249c6a
Compare
Contributor
Author
|
Note this is an data output change so the corresponding change in GrantNav is needed to be deployed simultaneously to avoid breakage. |
This should help maintain stability of the aggregate data in both the test data and to detect any changes/regressions in manage_entities_data output.
Contributor
Author
|
Requires: ThreeSixtyGiving/grantnav#1196 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.