Skip to content

Mw/redirect issue - #1187

Merged
michaelwood merged 3 commits into
livefrom
mw/redirect_issue
Jul 23, 2025
Merged

Mw/redirect issue#1187
michaelwood merged 3 commits into
livefrom
mw/redirect_issue

Conversation

@michaelwood

@michaelwood michaelwood commented Jul 21, 2025

Copy link
Copy Markdown

better solution for #1186

This function redirects a path and automatically adds a path to the url
string for use as source identifier in the request cycle.
Also move one of the util functions out of main views.py
@coveralls

coveralls commented Jul 21, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 16466730819

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 35 of 52 (67.31%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 74.309%

Changes Missing Coverage Covered Lines Changed/Added Lines %
grantnav/frontend/funders_search_view.py 3 4 75.0%
grantnav/frontend/recipients_search_view.py 3 4 75.0%
grantnav/frontend/views.py 14 20 70.0%
grantnav/frontend/org_utils.py 6 15 40.0%
Totals Coverage Status
Change from base Build 15847035733: 0.1%
Covered Lines: 1452
Relevant Lines: 1954

💛 - Coveralls

@michaelwood
michaelwood requested a review from R2ZER0 July 22, 2025 12:45
Comment thread grantnav/utils.py

@R2ZER0 R2ZER0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@michaelwood
michaelwood merged commit 8167ed3 into live Jul 23, 2025
6 checks passed
@michaelwood
michaelwood deleted the mw/redirect_issue branch July 23, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants