templates: search: Remove touchstart handler for loading overlay - #1189
Merged
Conversation
The touchstart function loads the overlay which is at a higher z-index than then element to be clicked. So the overlay loads but the element (usually a filter item) beneath the overlay doesn't receive a "click" Fixes: #1188
michaelwood
requested review from
R2ZER0 and
codemacabre
and removed request for
codemacabre
July 23, 2025 14:54
Pull Request Test Coverage Report for Build 16474093665Details
💛 - Coveralls |
R2ZER0
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The touchstart function loads the overlay which is at a higher z-index than then element to be clicked. So the overlay loads but the element (usually a filter item) beneath the overlay doesn't receive a "click"
Fixes: #1188