Re-opening PR: Fix wrong model layer and texture applied to openable armor#162
Open
Spyeedy wants to merge 3 commits intoThreeTAG:1.20/devfrom
Open
Re-opening PR: Fix wrong model layer and texture applied to openable armor#162Spyeedy wants to merge 3 commits intoThreeTAG:1.20/devfrom
Spyeedy wants to merge 3 commits intoThreeTAG:1.20/devfrom
Conversation
This commit fix is for armor renderers that set different model layers for "default" and "open" states, with 0 open timer. The bug fixed is, in the open state, the "default" model layer is used instead of the "open" model layer
Added an item, openable_test_chestplate, to test, to test and ensure the correct texture and model layer are selected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR is a duplicate of #148. I was renaming branches and well, this shit happened.
When a openable armor renderer has 2 different textures and 2 model layers for the "default" and "open" states, the textures and model layers are wrongly applied respectively.
For openable armor that has no open timer, the "default" state's model layer is used for the "open" state as well.
For openable armor that has a timer, the "open" texture is used for the default state. More specifically, the open animation's first frame texture is used.
This PR strives to fix this issue, and I pray that no further bugs were introduced for openable armors. I have tested it as vigorously as I could 😭. This bug drove me crazy 💀