Open
Conversation
…lladiumAnimationManager (other than the ability property, which can be switched out for any other method of defining an ability's animation)
…sn't repeatedly created
- Part A: animations (in json) can list bones from render layers, does nothing since they're not registered as bones in the animation controller - Part B: in DefaultPackRenderLayer, animate any parts that have an active bone in the active animation - (the unfinished part) manually add head.halo to the animation controller to demonstrate that A can link to B if the bone is registered beforehand TODO to finish, figure out exactly how early the bone needs to be registered, then either automatically register all active render layer bones, or define a way to manually register bones
- main issue is it doesn't work the first time you activate an animation, the model is always null whenever I first try to add the bones to the controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes use of the player animation library to play bedrock/blender animations when an ability is triggered
Animations are added to an ability by listing the animation's resourcelocation through it's properties, and can be set to animation layers: 0 (cosmetic) 1 (idle) 2 (active, default)
Doesn't disable or remove anything from the existing system, so you might have to disable it to see the effects