Skip to content

Conversation

@jodastephen
Copy link
Member

@jodastephen jodastephen commented Aug 15, 2025

Summary by CodeRabbit

  • Documentation
    • Corrected the Ethiopic calendar epoch alignment in the Javadoc, updating the mapping of Ethiopic 0001-01-01 to ISO 0008-08-27.
    • Clarified explanatory notes to ensure accurate date conversions and reduce confusion for users working with Ethiopic dates.
    • No functional, API, or behavioral changes; this is a documentation-only update.

@jodastephen jodastephen requested a review from Copilot August 15, 2025 22:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the Javadoc documentation for the Ethiopic calendar epoch alignment with the ISO calendar system. The documentation was incorrectly stating that the Ethiopic calendar start date corresponds to a different ISO date than the actual implementation.

  • Updates the epoch alignment documentation in two classes to reflect the correct ISO date correspondence
  • Changes the documented ISO date from 0284-08-29 to 0008-08-27 for the Ethiopic calendar start date 0001-01-01

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
EthiopicEra.java Updates Javadoc comment to correct the ISO date corresponding to Ethiopic epoch start
EthiopicChronology.java Updates Javadoc comment to correct the ISO date alignment documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@coderabbitai
Copy link

coderabbitai bot commented Aug 15, 2025

Walkthrough

Updated Javadoc in EthiopicChronology and EthiopicEra to correct the ISO date corresponding to Ethiopic 0001-01-01 from 0284-08-29 to 0008-08-27. No code, API, or behavior changes.

Changes

Cohort / File(s) Summary of Changes
Javadoc corrections (Ethiopic epoch mapping)
src/main/java/org/threeten/extra/chrono/EthiopicChronology.java, src/main/java/org/threeten/extra/chrono/EthiopicEra.java
Corrected documentation of epoch alignment: Ethiopic 0001-01-01 now mapped to ISO 0008-08-27 (was 0284-08-29). No logic or API changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I twitch my nose at dates so fine,
From 0284 to aught-eight’s line—
A hop, a skip, the epochs align,
Javadoc groomed, now crisp, divine.
Thump-thump! The timeline’s doing fine.

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8a44e41 and 7e7ef1a.

📒 Files selected for processing (2)
  • src/main/java/org/threeten/extra/chrono/EthiopicChronology.java (1 hunks)
  • src/main/java/org/threeten/extra/chrono/EthiopicEra.java (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build (11)
  • GitHub Check: build (11)
🔇 Additional comments (2)
src/main/java/org/threeten/extra/chrono/EthiopicChronology.java (1)

56-56: Epoch mapping sweep completed — all Ethiopic references updated.

  • Coptic classes still reference 0001-01-01 (Coptic) → 0284-08-29 (ISO), as expected.
  • EthiopicEra, EthiopicChronology and EthiopicDate consistently use 0001-01-01 (Ethiopic) → 0008-08-27 (ISO).
  • No stray occurrences of the old Ethiopic mapping remain.
src/main/java/org/threeten/extra/chrono/EthiopicEra.java (1)

45-45: All Ethiopic epoch references updated and consistent. The new start date (0001-01-01 (Ethiopic) → 0008-08-27 (ISO)) now matches across EthiopicEra, EthiopicChronology, and EthiopicDate. No stale references to the prior date remain in the codebase.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ethiopic

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jodastephen jodastephen merged commit d896bcf into main Aug 15, 2025
9 checks passed
@jodastephen jodastephen deleted the ethiopic branch August 15, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant