-
-
Couldn't load subscription status.
- Fork 79
Fix Ethiopic calendar epoch in Javadoc #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects the Javadoc documentation for the Ethiopic calendar epoch alignment with the ISO calendar system. The documentation was incorrectly stating that the Ethiopic calendar start date corresponds to a different ISO date than the actual implementation.
- Updates the epoch alignment documentation in two classes to reflect the correct ISO date correspondence
- Changes the documented ISO date from
0284-08-29to0008-08-27for the Ethiopic calendar start date0001-01-01
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| EthiopicEra.java | Updates Javadoc comment to correct the ISO date corresponding to Ethiopic epoch start |
| EthiopicChronology.java | Updates Javadoc comment to correct the ISO date alignment documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
WalkthroughUpdated Javadoc in EthiopicChronology and EthiopicEra to correct the ISO date corresponding to Ethiopic 0001-01-01 from 0284-08-29 to 0008-08-27. No code, API, or behavior changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (2)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit