e #8
Merged
e #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mods may send RPC's on a ShipStatus that aren't broadcasts. Previously Impostor would forbid that, which doesn't make sense to me. By moving down the check it'll allow mods to broadcast RPC's on ShipStatus. Reported-By: xtracube
I've checked Impostor for issues that are similar to Impostor#664, and found this one: if mods add a custom rpc on PlayerPhysics, Impostor will check ownership of it, which isn't intentional.
* Add diagnostic message to test HTTP server This makes it possible to diagnose if the reverse proxy setup is working correctly or if the game configuration is wrong * Print console log as well Only print it once to prevent console spam * Update src/Impostor.Server/Http/HelloController.cs Co-authored-by: js6pak <[email protected]> --------- Co-authored-by: js6pak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e