refactor: change from sync to bulk endpoints for transactions_lines and gl_accounts.#294
Merged
tobiascadee merged 8 commits intomainfrom Feb 20, 2026
Merged
Conversation
… and `gl_accounts`. all other streams will be full load. this will allow us to have more control over the start timestamp and it will now include all data, also deleted records.
There was a problem hiding this comment.
Pull request overview
This PR refactors two Exact Online streams to use the /bulk endpoints and switches their incremental replication from Timestamp to Modified, while making the remaining streams full-refresh (no replication key filtering).
Changes:
- Migrate
transaction_linesandgl_accountsfrom/sync/...to/bulk/...and change replication key toModified. - Remove
Timestampfrom the affected stream schemas (and fromgl_classifications_schemaas it’s no longer incremental). - Remove the legacy
ExactSyncStreamimplementation in favor of usingExactStreamdirectly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tap_exact/streams.py |
Switches stream classes/endpoints and replication keys (but currently still imports removed ExactSyncStream). |
tap_exact/schemas.py |
Removes Timestamp fields to align schemas with Modified-based replication/full-refresh behavior. |
tap_exact/client.py |
Simplifies URL param generation for incremental filtering and deletes the ExactSyncStream class. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all other streams will be full load. this will allow us to have more control over the start timestamp and it will now include all data, also deleted records.