Merged
Conversation
…m` base classes - Add `ExactBulkStream` and `ExactSyncStream` as specialised base classes for bulk and sync endpoints respectively - Add `deleted_schema` and `DeletedStream` to expose the Exact sync/Deleted endpoint - Switch `TransactionLinesStream` and `GLAccountsStream` to `ExactBulkStream` - Switch `GLClassificationsStream` to `ExactSyncStream` - Simplify schema imports in streams.py to use the `schemas` module directly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds support for Exact’s /sync/Deleted endpoint by introducing specialized stream base classes for bulk vs. sync endpoints, and registering a new deleted stream in the tap.
Changes:
- Introduce
ExactBulkStream(larger page size) andExactSyncStream(Timestamp-based filtering for/sync/*endpoints). - Add
DeletedStream(/sync/Deleted) withTimestampreplication key and a newdeleted_schema. - Migrate existing streams to the appropriate new base classes and simplify schema imports.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tap_exact/tap.py |
Registers the new DeletedStream in discover_streams(). |
tap_exact/streams.py |
Switches streams to ExactBulkStream/ExactSyncStream, adds DeletedStream, and consolidates schema imports. |
tap_exact/schemas.py |
Adds deleted_schema defining fields returned by /sync/Deleted. |
tap_exact/client.py |
Adds ExactBulkStream and ExactSyncStream stream base classes and sync-specific URL params. |
meltano.yml |
Updates the sample/project selection to only run deleted by default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExactBulkStreamandExactSyncStreamas specialised base classes for bulk and sync Exact API endpointsDeletedStream(sync/Deleted) that tracks deleted records with aTimestampreplication keydeleted_schemawith fields:ID,Timestamp,Division,DeletedBy,DeletedDate,EntityKey,EntityTypeTransactionLinesStreamandGLAccountsStreamtoExactBulkStream, andGLClassificationsStreamtoExactSyncStreamstreams.pyto use theschemasmodule directlyTest plan
deletedstream selected and verify records are returned fromsync/DeletedTimestampreplication keytransaction_lines,gl_accounts,gl_classifications) still function correctly after the base class change🤖 Generated with Claude Code