remove artifact navigation

[Tiendil]

No description provided.

[Copilot]

Pull request overview

This PR removes the "artifact navigation" abstraction layer from Donna and replaces it with a much simpler workflow-directory–based discovery model. The artifact-pattern/source/predicate/tag system, the view/list Jinja directives, the donna.lib.specification artifact kind, the --predicate CLI option, the skill-fixture sync mechanism, and the workspaces update command are all deleted; in their place, the config gains a workflow_dirs list (defaulting to ./workflows and ./.session/donna), a new centralized donna/domain/constants.py, and a new artifacts render command. Workflow documents are renamed/relocated under workflows/ and updated to reference plain Markdown spec files instead of via donna.lib.view(...).

Changes:

• Remove the artifact-navigation subsystem (patterns, sources, predicates, section tags, view/list directives, Specification kind, skill-sync, workspaces update).
• Introduce workflow_dirs configuration plus donna/domain/constants.py, and reshape config schema (session → session_dir, new default_section_kind/default_primary_section_kind/default_primary_section_id).
• Restructure CLI (artifacts view → artifacts render; artifacts validate accepts ids or --all; artifacts list loses pattern/predicate) and migrate all workflow docs into workflows/ referencing plain .md specs.

Reviewed changes

Copilot reviewed 71 out of 72 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
workflows/rfc/specs/request_for_change.md	Drop specification kind block; reword "artifact" → "file/Markdown document".
workflows/rfc/specs/design.md	Drop specification kind block; reword to plain Markdown.
workflows/rfc/request.donna.md	Drop workflow kind block; replace donna.lib.view/list with literal paths; rename prepare_rfc_artifact → prepare_rfc_document.
workflows/rfc/plan.donna.md	Drop workflow kind block.
workflows/rfc/do.donna.md	Drop workflow kind block; remove log_changes step.
workflows/rfc/design.donna.md	Drop workflow kind block; replace directives; rename prepare_design_artifact → prepare_design_document.
workflows/polish.donna.md	Drop workflow kind block.
specs/work/log_changes.donna.md	Delete obsolete log-changes workflow.
specs/intro.md	Drop specification kind block; revise glossary and pointers to reflect new workflows/ directory.
.agents/donna/usage/artifacts.md (and other .agents docs)	Documentation updates that still retain stale references to removed tags/--predicate features.
(other PR files)	Implementation of workflow_dirs, constants, render command, section primitives, and related refactors.

Comments suppressed due to low confidence (2)

.agents/donna/usage/artifacts.md:114

• The Artifact Tags section still documents a tags field on section configs and a --predicate '"workflow" in section.tags' example, but this PR removes the tags field from ArtifactSectionConfig and removes the --predicate option/ArtifactPredicate. This entire section (and the reference to "standard tags" on line 114, which is touched by the diff) is now stale and contradicts the new behavior described elsewhere in the same file.
  .agents/donna/intro.md:25
• These instructions tell the agent to "read the following files: **/*.donna.md" / **/*.md, but **/*.donna.md is a glob pattern, not a file. With the artifact-listing CLI (donna artifacts list) and view directives removed, this leaves the agent without concrete guidance on how to find workflows or documentation. Consider rewording to point at donna -p llm artifacts list (for workflows) and at concrete documentation roots (e.g. ./usage/, ./rfc/specs/) so the instruction is actionable.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.