Skip to content

Added the donna.lib.path(...) workflow directive#85

Merged
Tiendil merged 4 commits into
mainfrom
feature/proper-path-rendering-in-workflows
May 19, 2026
Merged

Added the donna.lib.path(...) workflow directive#85
Tiendil merged 4 commits into
mainfrom
feature/proper-path-rendering-in-workflows

Conversation

@Tiendil
Copy link
Copy Markdown
Owner

@Tiendil Tiendil commented May 19, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 19, 2026 10:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds donna.lib.path(...) as a workflow template directive for rendering normalized project paths, and broadens project path semantics so Donna paths can refer to files, directories, or future locations beyond workflow artifacts.

Changes:

  • Introduced the Path directive, library registration, tests, and workflow skill documentation.
  • Generalized project path validation/normalization while keeping artifact IDs constrained to .donna.md.
  • Updated RFC workflows, specs, README, AGENTS guidance, and release notes to use/document normalized path references.

Reviewed changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.

Show a summary per file
File Description
workflows/rfc/request.donna.md Uses donna.lib.path(...) for RFC spec references.
workflows/rfc/design.donna.md Uses donna.lib.path(...) for design spec references.
specs/behavior/skill_fixtures.md Requires workflow skill docs to describe the new path directive.
specs/behavior/file_paths.md Defines generalized project path and template path directive behavior.
specs/architecture/entities.md Adds guidance for narrow static typing suppressions.
README.md Mentions workflow text directives including donna.lib.path(...).
donna/workspaces/tests/test_paths.py Updates and extends path normalization tests.
donna/workspaces/tests/test_errors.py Removes tests for the deleted unsupported extension error.
donna/workspaces/tests/test_artifacts.py Updates artifact discovery expectations for generalized names.
donna/workspaces/paths.py Adds project path normalization and separates artifact ID validation.
donna/workspaces/errors.py Removes unsupported artifact extension workspace error.
donna/workspaces/artifacts.py Removes redundant artifact extension runtime check.
donna/skills/fixtures/workflows.md Documents donna.lib.path(...) usage and modes.
donna/primitives/directives/tests/test_path.py Adds tests for path directive argument handling and rendering.
donna/primitives/directives/path.py Implements the new path directive.
donna/primitives/directives/__init__.py Exports the new directive primitive.
donna/lib/tests/test_init.py Verifies donna.lib.path initialization.
donna/lib/__init__.py Registers the shared path directive instance.
donna/domain/tests/test_paths.py Adds project path domain validation tests.
donna/domain/tests/test_ids.py Renames section ID syntax tests and adds Unicode rejection coverage.
donna/domain/tests/test_artifact_ids.py Updates artifact ID validation coverage for generalized path segments.
donna/domain/paths.py Adds raw and validated project path primitives.
donna/domain/ids.py Renames section ID syntax helper.
donna/domain/artifact_ids.py Bases artifact validation on project paths plus .donna.md.
donna/cli/types.py Updates artifact CLI parsing around generalized path normalization.
changes/next_release.md Adds release notes for the directive and path handling changes.
AGENTS.md Adds guidance for using the polish workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tiendil Tiendil merged commit 68a3f54 into main May 19, 2026
5 checks passed
@Tiendil Tiendil deleted the feature/proper-path-rendering-in-workflows branch May 19, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants