Added the donna.lib.path(...) workflow directive#85
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds donna.lib.path(...) as a workflow template directive for rendering normalized project paths, and broadens project path semantics so Donna paths can refer to files, directories, or future locations beyond workflow artifacts.
Changes:
- Introduced the
Pathdirective, library registration, tests, and workflow skill documentation. - Generalized project path validation/normalization while keeping artifact IDs constrained to
.donna.md. - Updated RFC workflows, specs, README, AGENTS guidance, and release notes to use/document normalized path references.
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
workflows/rfc/request.donna.md |
Uses donna.lib.path(...) for RFC spec references. |
workflows/rfc/design.donna.md |
Uses donna.lib.path(...) for design spec references. |
specs/behavior/skill_fixtures.md |
Requires workflow skill docs to describe the new path directive. |
specs/behavior/file_paths.md |
Defines generalized project path and template path directive behavior. |
specs/architecture/entities.md |
Adds guidance for narrow static typing suppressions. |
README.md |
Mentions workflow text directives including donna.lib.path(...). |
donna/workspaces/tests/test_paths.py |
Updates and extends path normalization tests. |
donna/workspaces/tests/test_errors.py |
Removes tests for the deleted unsupported extension error. |
donna/workspaces/tests/test_artifacts.py |
Updates artifact discovery expectations for generalized names. |
donna/workspaces/paths.py |
Adds project path normalization and separates artifact ID validation. |
donna/workspaces/errors.py |
Removes unsupported artifact extension workspace error. |
donna/workspaces/artifacts.py |
Removes redundant artifact extension runtime check. |
donna/skills/fixtures/workflows.md |
Documents donna.lib.path(...) usage and modes. |
donna/primitives/directives/tests/test_path.py |
Adds tests for path directive argument handling and rendering. |
donna/primitives/directives/path.py |
Implements the new path directive. |
donna/primitives/directives/__init__.py |
Exports the new directive primitive. |
donna/lib/tests/test_init.py |
Verifies donna.lib.path initialization. |
donna/lib/__init__.py |
Registers the shared path directive instance. |
donna/domain/tests/test_paths.py |
Adds project path domain validation tests. |
donna/domain/tests/test_ids.py |
Renames section ID syntax tests and adds Unicode rejection coverage. |
donna/domain/tests/test_artifact_ids.py |
Updates artifact ID validation coverage for generalized path segments. |
donna/domain/paths.py |
Adds raw and validated project path primitives. |
donna/domain/ids.py |
Renames section ID syntax helper. |
donna/domain/artifact_ids.py |
Bases artifact validation on project paths plus .donna.md. |
donna/cli/types.py |
Updates artifact CLI parsing around generalized path normalization. |
changes/next_release.md |
Adds release notes for the directive and path handling changes. |
AGENTS.md |
Adds guidance for using the polish workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.