Skip to content

feat: App customisation#180

Open
akselotti wants to merge 8 commits intomainfrom
customisation-settings
Open

feat: App customisation#180
akselotti wants to merge 8 commits intomainfrom
customisation-settings

Conversation

@akselotti
Copy link
Copy Markdown
Contributor

@akselotti akselotti commented Mar 27, 2026

No description provided.

@akselotti akselotti linked an issue Mar 27, 2026 that may be closed by this pull request
Customize organization name and logos #166
Open
@akselotti

This comment was marked as resolved.

Sign in to view
@MikaelSiidorow

This comment was marked as resolved.

Sign in to view
@akselotti akselotti force-pushed the customisation-settings branch from df9cf75 to 2fba83f Compare March 28, 2026 10:54
@akselotti
Copy link
Copy Markdown
Contributor Author

akselotti commented Mar 28, 2026

I splitted the changes into two branches with separate PRs. This branch is stacked on top of the drizzle-upgrade branch (#184) and therefore shows the commits from there as well. I’ll re-force-push this branch once the Drizzle upgrade looks good.

@akselotti akselotti force-pushed the customisation-settings branch 8 times, most recently from 28985ad to b253e2f Compare March 31, 2026 16:25
@akselotti akselotti force-pushed the customisation-settings branch from b253e2f to 3d0997e Compare April 1, 2026 08:45
@akselotti
Copy link
Copy Markdown
Contributor Author

akselotti commented Apr 1, 2026

Vibe coded the tests to pass. It proposed a simple change of modifying the secure field in cookie definition to be false if in TEST environment. I’m not sure if this is in the interest of testing, but every test seems to pass now.

lajp
lajp reviewed Apr 1, 2026
View reviewed changes
Comment thread src/lib/i18n/en/index.ts
emails: {
otp: {
subject: "CSG Membership Registry Sign In Code",
subject: "{organizationName} Membership Registry Sign In Code",
Copy link
Copy Markdown
Member

@lajp lajp Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a different variable for organizationNameShort?

Copy link
Copy Markdown
Contributor Author

@akselotti akselotti Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, true, probably. I’ll add it and make the emails use that. I’ll leave the footer and other UI components as is. Let’s see where this takes us.

Comment thread src/lib/i18n/en/index.ts Outdated
},

customise: {
title: "App Customisations",
Copy link
Copy Markdown
Member

@lajp lajp Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: "Customisation" is the British English spelling of the word while the rest of the codebase uses American English spelling

Copy link
Copy Markdown
Contributor Author

@akselotti akselotti Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being a coloniser :D

@akselotti akselotti force-pushed the customisation-settings branch 2 times, most recently from 6771ef7 to e08b749 Compare April 2, 2026 13:49
@akselotti akselotti force-pushed the customisation-settings branch from e08b749 to 56d0cfe Compare April 2, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lajp lajp lajp left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Customize organization name and logos

3 participants

@akselotti @MikaelSiidorow @lajp