RFC: Redesign membership model for indefinite memberships#195
Open
MikaelSiidorow wants to merge 1 commit intomainfrom
Open
RFC: Redesign membership model for indefinite memberships#195MikaelSiidorow wants to merge 1 commit intomainfrom
MikaelSiidorow wants to merge 1 commit intomainfrom
Conversation
Proposes restructuring the membership data model to align with Finnish association law where membership is indefinite with periodic payment obligations, replacing the current kide.app-inspired periodic model. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Membership in Finnish associations is legally indefinite ("toistaiseksi") with periodic payment obligations. Our current data model (inherited from kide.app) treats each year as a separate membership period, which doesn't match reality and causes confusing UI states like "resigned" on renewals.
This RFC proposes restructuring the model:
memberbecomes the ongoing relationship (user x type), not a per-period recordpayment(new) tracks individual payments linked to membership periodsmembershipPeriod(renamed frommembership) stays as admin-created yearly periods with due dates and Stripe pricesCritical design decisions
yearinstead of full dates. Import is idempotent and order-independent — re-derives member rows from payment history on each run.Full spec in
docs/superpowers/specs/2026-04-03-membership-model-redesign.md.🤖 Generated with Claude Code