Skip to content

fix: repair the corrupted version file#14

Merged
JarbasAl merged 2 commits into
devfrom
fix-version-file
May 21, 2026
Merged

fix: repair the corrupted version file#14
JarbasAl merged 2 commits into
devfrom
fix-version-file

Conversation

@JarbasAl

Copy link
Copy Markdown
Contributor

Summary

markovonnx/version.py was invalid. It contained a END_VERSION_BLOCK marker
immediately concatenated with a duplicated module docstring and a second
__version__ line, and __version__ was hard-coded to "0.3.0" independently
of the version block (which itself read 0.0.1a3).

Because __version__ was hard-coded, the release automation's bumps to the
# START_VERSION_BLOCK fields never reached the value setuptools reads via
[tool.setuptools.dynamic].

This rewrites the file to the canonical format: a clean version block plus a
__version__ derived from those fields. The block is set to 0.3.0 — the
current published version — so the automation can take over bumping from there.

# START_VERSION_BLOCK
VERSION_MAJOR = 0
VERSION_MINOR = 3
VERSION_BUILD = 0
VERSION_ALPHA = 0
# END_VERSION_BLOCK

__version__ = f"{VERSION_MAJOR}.{VERSION_MINOR}.{VERSION_BUILD}" + (
    f"a{VERSION_ALPHA}" if VERSION_ALPHA else ""
)

Test plan

  • version.py imports and __version__ == "0.3.0"
  • pyproject.toml dynamic version resolves on build

version.py had a duplicated docstring concatenated onto END_VERSION_BLOCK and
a hard-coded __version__ that ignored the version block. Derive __version__
from the block fields so the release automation's bumps take effect.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@JarbasAl has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 37 minutes and 31 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 492192ea-e7ad-4a26-bda9-f5a6f9d10c34

📥 Commits

Reviewing files that changed from the base of the PR and between 8d715da and e058687.

📒 Files selected for processing (1)
  • markovonnx/version.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-version-file

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the fix label May 21, 2026
@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown

I've gathered some intelligence on your latest changes. 🕵️‍♀️

I've aggregated the results of the automated checks for this PR below.

📋 Repo Health

A routine checkup to keep the repo running smoothly. 🏥

✅ All required files present.

Latest Version: 1.0.0a1

markovonnx/version.py — Version file
README.md — README
LICENSE — License file
pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
CHANGELOG.md — Changelog
markovonnx/version.py has valid version block markers

🔒 Security (pip-audit)

Scanning for any signs of suspicious activity. 🕵️‍♂️

✅ No known vulnerabilities found (39 packages scanned).

⚖️ License Check

I've verified the attribution of all third-party code. 👤

❌ License violations detected (11 packages) — review required before merging.

Dependency                          License Name                                            License Type         Misc                                    
pyproject_hooks:1.2.0               Error                                                   Error                                                        

License Type                        Found                                                  
Error                               1

License distribution: 3× Apache-2.0, 2× MIT License, 1× 3-Clause BSD License, 1× Apache Software License, 1× Apache-2.0 OR BSD-2-Clause, 1× BSD-3-Clause AND 0BSD AND MIT AND Zlib AND CC0-1.0, 1× MIT, 1× PSF-2.0

Full breakdown — 11 packages
Package Version License URL
build 1.5.0 MIT link
flatbuffers 25.12.19 Apache Software License link
markovonnx 1.0.0a1 Apache-2.0
ml_dtypes 0.5.4 Apache-2.0 link
numpy 2.4.6 BSD-3-Clause AND 0BSD AND MIT AND Zlib AND CC0-1.0 link
onnx 1.21.0 Apache-2.0 link
onnxruntime 1.26.0 MIT License link
packaging 26.2 Apache-2.0 OR BSD-2-Clause link
protobuf 7.35.0 3-Clause BSD License link
pyproject_hooks 1.2.0 MIT License link
typing_extensions 4.15.0 PSF-2.0 link

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🏷️ Release Preview

Checking if we've included all the important changes. 📋

Current: 0.3.0Next: 0.3.1a1

Signal Value
Label (none)
PR title fix: repair the corrupted version file
Bump build

✅ PR title follows conventional commit format.


🚀 Release Channel Compatibility

Predicted next version: 0.3.1a1

Channel Status Note Current Constraint
Stable Not in channel -
Testing Not in channel -
Alpha Not in channel -

🔌 Plugin Detection

Ensuring the plugin's 'icon' (if any) is looking sharp. 🎨

ℹ️ Not an OVOS plugin — OPM check skipped.

📊 Coverage

Is the code fully immunized with tests? 💉

85.5% total coverage

Files below 80% coverage (1 file)
File Coverage Missing lines
markovonnx/opm.py 69.2% 139

Full report: download the coverage-report artifact.

🔨 Build Tests

The build is fresh out of the oven! 🥯

✅ All versions pass

Python Build Install Tests
3.10
3.11
3.12
3.13
3.14

Stay curious and keep coding! 🚀

@JarbasAl JarbasAl merged commit 67c6829 into dev May 21, 2026
10 of 12 checks passed
@JarbasAl JarbasAl deleted the fix-version-file branch May 21, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant