Remove support for HDFS #2185
Merged
Remove support for HDFS #2185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kounelisagis
changed the title
kounelisagis
requested changes
Apr 15, 2025
There was a problem hiding this comment.
All of the changes should be made conditionally based on the libtiledb version. The same should also have been done for #2184.
Doesn't TileDB-Py only support a single minor release of TileDB at a time? I don't see the value in adding conditional logic to support TileDB<2.28 if that is not supported.
I'm not overly worried about #2184. That test was super basic. Do you want me to send a follow-up PR to restore that test for TileDB<=2.27? |
kounelisagis
force-pushed
the
remove-hdfs
branch
from
ad2b827 to
b2bbb19
Compare
|
The test is failing because the token is missing after forking. |
kounelisagis
changed the title
kounelisagis
approved these changes
Apr 25, 2025
teo-tsirpanis
approved these changes
Apr 25, 2025
jdblischak
commented
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2184. HDFS support was removed upstream in TileDB via TileDB-Inc/TileDB#5496. However, this change hasn't been released yet, so I leave it to @kounelisagis to decide when it makes sense to merge this PR.
[sc-66019]