Fix intermittently failing schema evolution UT #5517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rroelke
reviewed
May 27, 2025
| @@ -1106,15 +1106,15 @@ void test_schema_evolution_drop_fixed_add_var( | |||
|
|
|||
| // Evolve schema to drop attribute "a" | |||
| ArraySchemaEvolution schema_evolution = ArraySchemaEvolution(ctx); | |||
| uint64_t now = tiledb_timestamp_now_ms() + 1; | |||
| uint64_t now = fragment_write_ts + 1; | |||
| schema_evolution.set_timestamp_range(std::make_pair(now, now)); | |||
| schema_evolution.drop_attribute("a"); | |||
| schema_evolution.array_evolve(array_uri); | |||
| std::this_thread::sleep_for(std::chrono::milliseconds(100)); | |||
There was a problem hiding this comment.
Looks like the expectation is that now_ms() returns the same thing twice, right?
Given this sleep_for here, how does that happen?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightlies have been failing often on MacOS and ubuntu machines. I have reproduced locally on my laptop as well.
This is fixing the flaky behavior by making sure we remove and add an attribute to an array at the same timestamp, causing non deterministic schema evolution result.
This also removes a wrong assert that fails when building in debug mode.
TYPE: NO_HISTORY
DESC: Fix intermittently failing schema evolution UT