Closed
Conversation
- Fix broken YAML syntax for FALKORDB_MAX_CONNECTIONS and FALKORDB_RETRY_ON_TIMEOUT env vars - Make Pinecone serverless cloud/region configurable via env vars - Add defensive import for optional TaskPollResponse - Update default model from gpt-3.5-turbo to gpt-4.1-nano - Add vscode to gitignore
2dbae19 to
ea5b0a5
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| llm: Optional[str] = Field(default="openai") | ||
| gptkey: Optional[SecretStr] = "sk" | ||
| model: Union[str, LlmEmbeddingModel] = Field(default="gpt-3.5-turbo") | ||
| model: Union[str, LlmEmbeddingModel] = Field(default="gpt-4.1-nano") |
There was a problem hiding this comment.
Inconsistent default model update across sibling classes
Low Severity
The default model in QuestionAnswer was updated to gpt-4.1-nano, but QuestionToLLM in the same file (line 242) still defaults to gpt-3.5-turbo. Both classes are used for user-facing API endpoints (/api/qa/* and /api/ask respectively), and before this change they shared the same default. This creates a new inconsistency where two similar request models silently resolve to different models depending on which endpoint a user hits without specifying a model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


POST: add PINECONE .env vars
Note
Medium Risk
Medium risk because it changes the default LLM model used for
/api/qarequests and alters Pinecone index-creation parameters via new env vars, which can affect runtime behavior and costs.Overview
Fixes broken Docker Compose environment variable entries for
FALKORDB_MAX_CONNECTIONSandFALKORDB_RETRY_ON_TIMEOUT, and adds aMakefileto standardize commondocker composeoperations.Makes Pinecone serverless index creation configurable via
PINECONE_SERVERLESS_CLOUDandPINECONE_SERVERLESS_REGIONinstead of hardcoded values.Improves modular startup by providing a fallback
TaskPollResponseschema when the optional knowledge-graph module isn’t installed, and updates the defaultQuestionAnswer.modelfromgpt-3.5-turbotogpt-4.1-nano. Also ignores VS Code artifacts via.gitignore.Written by Cursor Bugbot for commit ea5b0a5. This will update automatically on new commits. Configure here.