Skip to content

Chore/audit minor fixes - #28

Merged
TimInTech merged 5 commits into
mainfrom
chore/audit-minor-fixes
Oct 5, 2025
Merged

Chore/audit minor fixes#28
TimInTech merged 5 commits into
mainfrom
chore/audit-minor-fixes

Conversation

@TimInTech

Copy link
Copy Markdown
Owner

Pull Request – Simulation Only

Summary

Describe what this PR changes (scripts, docs). No commands are executed in this workspace.

Checklist

  • No commands executed locally; all steps are simulated/explained only.
  • Changes are limited to scripts and/or documentation.
  • SIMULATION.md updated to reflect behavior and risks.
  • If adding a new script or option, included example usage commands (chmod +x; ./script; screen -r ...).
  • Security considerations addressed (least-privilege user, ports, backups).

Testing (Simulation)

Explain expected side effects if run on a proper host (files created, services started, ports opened). Include rollback/cleanup notes.

Copilot AI review requested due to automatic review settings October 5, 2025 21:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses minor issues and improvements across the Minecraft server setup scripts and documentation. The changes focus on fixing permissions, improving security through SHA256 verification, correcting documentation inconsistencies, and fixing a broken URL reference.

  • Enhanced security by adding SHA256 verification to the PaperMC update process
  • Fixed permission issues by ensuring proper ownership of files by the minecraft user
  • Corrected documentation to consistently show proper screen session access commands

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
setup_minecraft_lxc.sh Added file ownership fix to ensure minecraft user owns all files
setup_minecraft.sh Enhanced update script with SHA256 verification, fixed permissions, and corrected screen access command
scripts/proxmox_create_ct_bedrock.sh Fixed broken GitHub URL reference
README.md Updated documentation to show correct screen access commands and improved status section
.github/copilot-instructions.md Corrected screen access commands and cleaned up formatting

@TimInTech
TimInTech merged commit 05b4756 into main Oct 5, 2025
2 checks passed
@TimInTech
TimInTech deleted the chore/audit-minor-fixes branch October 5, 2025 21:24
@TimInTech

Copy link
Copy Markdown
Owner Author

Zusammenfassung

  • Konsistenter Besitz von /opt/minecraft vor Start sichergestellt (VM+LXC).
  • Console-Attach-Beispiele auf sudo -u minecraft screen -r … korrigiert (README, Copilot-Doku).
  • In VM-Installer: eingebettetes update.sh auf SHA256-geprüfte PaperMC-Logik umgestellt.
  • Proxmox-Helper: falsche raw.githubusercontent.com-URL (mit .git) behoben.

Sicherheit/Qualität

  • Strikter Bash-Modus bleibt erhalten (set -euo pipefail).
  • ShellCheck läuft via Workflow; lokale Syntax-Checks grün.
  • Keine Ausführung von Installer-Skripten im PR (reine Textänderungen).

Risiken

  • Keine Verhaltensänderung am Serverstart, nur Besitz- und Doku-Korrekturen.

Tests (Simulation)

  • bash -n auf allen Skripten OK.
  • ShellCheck in CI prüft *.sh und **/*.sh.

Bitte mergen, wenn CI grün ist.

@TimInTech
TimInTech restored the chore/audit-minor-fixes branch October 5, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants