feat: add tafsut model - #370
Open
AzulGarza wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change follows existing shim conventions, updates dependencies coherently, and includes corresponding tests and documentation updates.
Pull request overview
Adds Huawei’s Tafsut foundation model to the TimeCopilot model surface by bumping the foundationforecast dependency and re-exporting the new model through the existing timecopilot.models.foundation.* shim pattern.
Changes:
- Bump
foundationforecastto>=0.1.2and update lockfile to include the newtafsutdependency. - Add
Tafsutshim model attimecopilot.models.foundation.tafsutand export it from the foundation package. - Add basic tests and documentation/changelog entries for the new model and release.
File summaries
| File | Description |
|---|---|
uv.lock |
Updates resolved deps: foundationforecast 0.1.2 and adds tafsut package entry. |
pyproject.toml |
Bumps foundationforecast minimum version and package version to 0.0.31. |
timecopilot/models/foundation/tafsut.py |
Introduces Tafsut shim class re-exporting foundationforecast implementation. |
timecopilot/models/foundation/__init__.py |
Exports Tafsut from the foundation models namespace. |
tests/models/foundation/test_tafsut.py |
Adds a smoke test to ensure Tafsut runs end-to-end via TimeCopilotForecaster. |
tests/models/foundation/test_shims.py |
Includes Tafsut in shim type checks. |
tests/models/conftest.py |
Adds Tafsut to the shared model matrix used by general model tests. |
docs/changelogs/v0.0.31.md |
Documents Tafsut support and the foundationforecast move, with links and usage snippet. |
docs/api/models/foundation/models.md |
Adds Tafsut to the API docs build list. |
Review details
- Files reviewed: 8/10 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this prs adds the tafsut model by Huawei