This repository was archived by the owner on Dec 6, 2022. It is now read-only.
Treat instances of DateTimeInterface as a value type throughout the API #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance:
Due to strict comparisons on the group by this would yield some rather unexpected results:
When what is actually wanted is:
This PR changes the
Identity::hash
behaviour such that DateTimes are treated as a value type based on their timestamps (and class name) which would solve this problem.