-
Notifications
You must be signed in to change notification settings - Fork 134
feat: enable Basic var and List var to coexist for the local search #1606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@triceo I plan to add documentation about the mixed model once I finish the quick-start change, as I'll have concrete models to use in the explanation. |
755fe45
to
1a78122
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This continues to be suspiciously simple. I am really surprised.
Did you test what happens when strength/difficulty comparisons are used? Did you check entity/value sorter manner? We do not support some of it with list variables, and we need to make sure that this does not change here; and the use cases which work still need to work in the mixed mode.
If there is coverage for the mentioned features, then we know the default behavior remains unchanged. I'll ensure to add tests for the relevant features. |
1a78122
to
06da606
Compare
165e5c2
to
8223d2c
Compare
5c951a8
to
185e79c
Compare
e4ba841
to
014d677
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after comments resolved.
...c/main/java/ai/timefold/solver/core/impl/constructionheuristic/placer/QueuedValuePlacer.java
Outdated
Show resolved
Hide resolved
...a/ai/timefold/solver/core/testdomain/mixed/singleentity/MixedCustomBasicVariableFactory.java
Outdated
Show resolved
Hide resolved
core/src/test/java/ai/timefold/solver/core/testdomain/mixed/singleentity/MixedCustomPhase.java
Outdated
Show resolved
Hide resolved
.../ai/timefold/solver/core/testdomain/mixed/singleentity/MixedCustomBasicVariableSwapMove.java
Outdated
Show resolved
Hide resolved
...t/java/ai/timefold/solver/core/testdomain/mixed/singleentity/TestdataMixedValueListener.java
Outdated
Show resolved
Hide resolved
ef2e929
to
11af3d6
Compare
|
This PR completes the feature and enables the mixed model for local search.