#1984 Restore GSE.PlayerSpellsLoaded so the editor opens in combat again - #1985
Closed
LarryThiessen wants to merge 1 commit into
Closed
#1984 Restore GSE.PlayerSpellsLoaded so the editor opens in combat again#1985LarryThiessen wants to merge 1 commit into
LarryThiessen wants to merge 1 commit into
Conversation
…n combat again e2c2355 (TimothyLuke#1752) allowed GSE.ShowSequences to open during combat when GSE.PlayerSpellsLoaded() reported the spellbook ready, with the function defined in GSE_QoL. A later refactor deleted the definition, leaving the Editor.lua call dangling on nil -- the gate silently collapsed back to "always block in combat", while the ungated Keybindings button kept opening the very same editor window in combat without error. Reimplement PlayerSpellsLoaded in GSE_QoL as a stateless spellbook check (C_SpellBook.GetNumSpellBookSkillLines on Retail, GetNumSpellTabs fallback on Classic) -- no cache to maintain, same semantics the old scanned playerSpells table answered. Editor.lua is untouched; builds without GSE_QoL keep the existing block-in-combat behaviour. Fixes TimothyLuke#1984 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
|
This has failed build checks and needs corrections before it can be merged. |
Owner
|
ixed this a different way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1984
Problem
GSE.ShowSequences()blocks in combat, whileGSE.ShowKeyBindings()opens the same editor window in combat with no error. The combat-open feature from #1752 (e2c2355) regressed: its gate callsGSE.PlayerSpellsLoaded(), whose GSE_QoL definition was deleted in a later refactor — the reference now resolves to nil, so the escape hatch never fires and the editor always refuses in combat.Fix
Reimplement
GSE.PlayerSpellsLoaded()inGSE_QoL/QoL.luawhere it originally lived, but stateless — ask the spellbook directly instead of maintaining the old scannedplayerSpellscache:C_SpellBook.GetNumSpellBookSkillLines() > 0GetNumSpellTabs() > 0Editor.luais untouched (its gate already calls the function when present). Builds without GSE_QoL keep the current block-in-combat behaviour, matching how #1752 originally shipped.Verified
In-game: with the fix, opening Sequences during combat works with no Lua error — identical to the Keybindings path.
luac -pclean. 1 file, +19.🤖 Generated with Claude Code