#1986 Icon system: filter stealth states; list all conditional branches in Select Icon - #1987
Merged
TimothyLuke merged 1 commit intoAug 20, 2026
Conversation
…onal branches in Select Icon
- FORM_SPELL_IDS: add Stealth (1784) and Prowl (5215), plus exact-name
matches in isFormSpellCandidate, so stealth-management lines like
"/cast [nostealth] Stealth; [stealth,nocombat] Sprint" no longer steal
the block's auto-icon (stealth states sit on the stance bar exactly
like stances/forms).
- Select Icon menu: new menu-only candidate source enumerates every
";"-separated branch of a cast line with conditionals stripped, so
spells behind currently-false conditionals ("/cast [combat] X" edited
out of combat) are offered in the picker. Deduped via the existing
addIconMenuCandidates. The auto-icon continues to use the live
resolver, unchanged by design.
Fixes TimothyLuke#1986
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1986
Problem
/cast [nostealth] Stealth; [stealth,nocombat] Sprintresolves to "Stealth" (unstealthed) and takes the block icon from the real ability below it./cast [combat] Shuriken Stormcan't be picked. Castsequence lines enumerate element-wise (conditionals ignored), so line types behaved inconsistently.Fix
GSE_GUI/Editor.luaonly, +42/−0:FORM_SPELL_IDSgains Stealth (1784) + Prowl (5215);isFormSpellCandidatematches the names — same pattern as the existing stance/form/Call Pet entries.getAllConditionalBranchSpells()(menu-only) enumerates every;-branch with conditionals stripped, fed through the existingaddIconMenuCandidatesdedupe; one call added in the menu-build loop. Auto-icon resolution is untouched — it deliberately keeps following live conditionals.Verified
In-game: the Rogue block above now icons from the real ability, not Stealth; Select Icon lists
[combat]-gated spells while out of combat.luac -pclean.Known corners (accepted): while actually stealthed out of combat that management line resolves to Sprint (not a stance → may icon; rare editing state). The new enumerator resolves spells only — item branches in
/use [cond] Item; …rely on the pre-existing fallback path, as before.🤖 Generated with Claude Code