#1989 Restore the Patron Tab spell list in the Sequence Editor

[LarryThiessen]

Fixes #1989

Problem

Pre-#1914, the Patron QoL wired Tab in an Action block's spell field and macro box to a menu: Insert Spell (player spellbook) + Insert GSE Variable. The AceGUI-removal restructure (a32c1c6) removed that code, its playerSpells cache, and the L["Insert Spell"] locale key when the Macro Insertion Toolbar moved to the external GSE_MacroToolbar addon — Tab in a MacroBlock has done nothing since.

Fix

3 files, +77/−0, in the modern hook style (matches the surviving OnEditorBooleanTab):

• QoL.lua — getPlayerSpells(): stateless on-demand spellbook enumeration (active/non-passive/non-offspec, sorted; replaces the old 4-event cache). GSE.OnEditorSpellTab (spell field, applies via callback so the field's handlers store) + GSE.OnEditorMacroBlockTab (macro box, cursor insert; the box's OnTextChanged owns storage — the old stray action.spell write is deliberately not restored).
• Editor.lua — both hooks invoked (guarded, no-op without GSE_QoL) at the end of the spell/macro editbox factory.
• ModL_enUS.lua — restore L["Insert Spell"] = true (absence raised AceLocale "Missing entry" on menu open).

Verified

In-game: Tab pops the menu in both fields, spells insert at cursor / set the field, no locale error. luac -p clean on all three files.

🤖 Generated with Claude Code

[TimothyLuke]

while this works for Retail it fails on some classic variants which dont implement C_SpellBook. Reworking to cover both

[TimothyLuke]

Pushed 847784f to this branch — the Classic path was missing.

getPlayerSpells returned an empty table whenever C_SpellBook was absent, so on Classic the menu opened with an Insert Spell heading and nothing under it. And the guard tested the table, which is the sharper edge: TBC Classic Anniversary and MoP Classic expose C_SpellBook without all of its functions, so they pass C_SpellBook and C_SpellBook.GetNumSpellBookSkillLines… and then find no working skill-line API. That's the same trap already documented on spellIDIsInSpellBook in GSE/API/translator.lua — the one that produced ~179 errors per save in #1925. The choice is now made per function, requiring every call the modern loop actually makes.

The Classic branch walks tabs rather than skill lines — GetNumSpellTabs / GetSpellTabInfo for offsets, GetSpellBookItemName for the name, IsPassiveSpell and GetSpellBookItemInfo for the filtering the modern API does with fields on an info table. Three things there have no Retail equivalent:

• Ranks. Classic lists one row per rank, so names are deduped — a macro wants the name anyway, since /cast <name> already picks the highest rank known.
• FUTURESPELL rows are the greyed-out not-yet-learned entries; only "SPELL" is castable.
• offSpecID from GetSpellTabInfo (Cata+, nil before it) stands in for isOffSpec, so another spec's book is skipped.

A client with neither API now returns an empty list rather than erroring — which is what every Classic client hit before.

.luacheckrc gains the five Classic globals; without them the build fails on undefined-variable warnings.

spec/spellbook_spec.lua covers both APIs plus the cases a Retail test run can't reach: the partial-C_SpellBook client, the off-spec tab, ranks collapsing, a client with no item-info call, and no spellbook API at all. 156 tests, luacheck clean across all 67 files.

The rest of the PR I left as-is — restoring the hooks in the modern pattern rather than the old cache is the right call, and deliberately not re-writing action.spell from the macro box matches what the field's own handlers expect.