#1997 Tab spell list: insert at the remembered caret, not the end of the row - #2000
Merged
TimothyLuke merged 1 commit intoAug 22, 2026
Merged
Conversation
…the end of the row Between pressing Tab and clicking the entry, the editor's debounced live repaint (or a focus-loss commit repaint) can SetText the box, parking the caret at the end -- so a plain Insert sometimes landed at the end of the last row. Remember the caret at Tab-press, cancel any pending live repaint via the gseRecolourToken the recolour already honours, and on pick do SetFocus + SetCursorPosition(saved) + Insert. Fixes TimothyLuke#1997 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1997
Stacked on PR #1995 (same function — once #1995 merges this collapses to the single commit
b33ab195).Problem
Between pressing Tab and clicking the entry, the editor's debounced live repaint (or a focus-loss commit repaint) can
SetTextthe box, parking the caret at the end — so a plainInsertsometimes landed at the end of the last row.Fix (GSE_QoL/QoL.lua,
OnEditorMacroBlockTab)Remember the caret at Tab-press, cancel any pending live repaint via the
gseRecolourTokenthe recolour already honours, and on pick doSetFocus+SetCursorPosition(saved)+Insert. No colouring changes.Verified in-game.
luac -pclean.🤖 Generated with Claude Code