#2002 Keep a macro block's height fit inside the block - #2005
Merged
TimothyLuke merged 1 commit intoAug 23, 2026
Merged
Conversation
FitMacroEditBoxToContent pushes the height delta of a re-fitted macro command box up through its fixed-height ancestors, but the walk ran to the top of the widget tree. Only the containers inside a block should absorb that delta; above the block panel sit shared containers -- the block list, the layout container, the scroll frame -- and every block's fit on load subtracted its own delta from those same containers again. On a multi-action sequence that collapsed the list area by roughly the sum of the blocks' deltas, so the editor no longer filled the window and the last block was clipped. Stop resizing once the walk reaches the first auto-height ancestor: that container recomputes its height from its children, and everything above it follows normally. Past that boundary we only re-lay out. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2002
Since the macro-command box auto-fit, opening a sequence with several action blocks left the block list short — it stopped before the bottom of the window with empty space below and the last block clipped.
FitMacroEditBoxToContentpushes the delta of a re-fitted box up through its fixed-height ancestors, but the walk ran to the top of the widget tree. Only the containers inside a block should absorb that delta; above the block panel sit shared containers (block list, layout container, scroll frame), and every block's fit on load subtracted its own delta from those same containers again — roughly -36px per block going from the 5-row baseline to the 3-row minimum.The walk now stops resizing at the first auto-height ancestor, which recomputes its height from its children; above that boundary it only re-lays out.
Testing
luac -pclean.🤖 Generated with Claude Code