Add landscape orientation tests #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinder-emanharoutunian
requested a review
from tinder-cfuller
as a code owner
tinder-emanharoutunian
changed the base branch from
main
to
fix/consistent-test-implementations
Co-authored-by: Christopher Fuller <[email protected]>
Comment on lines
68
to
70
| // Primary purpose is to bypass an issue when snapshot testing margins on devices with a home button such as the | ||
| // iPhone 8/SE. Please see [here](https://github.com/pointfreeco/swift-snapshot-testing/issues/750) | ||
| // and [here](https://github.com/pointfreeco/swift-snapshot-testing/pull/757) |
Collaborator
There was a problem hiding this comment.
I believe this language can be improved. Maybe something such as:
Suggested change
| // Primary purpose is to bypass an issue when snapshot testing margins on devices with a home button such as the | |
| // iPhone 8/SE. Please see [here](https://github.com/pointfreeco/swift-snapshot-testing/issues/750) | |
| // and [here](https://github.com/pointfreeco/swift-snapshot-testing/pull/757) | |
| /// Used to avoid a bug causing invalid snapshots on devices with a home button. | |
| /// | |
| /// May be removed and replaced with `allTestDevices` once snapshot issue is fixed. | |
| /// | |
| /// Links: | |
| /// https://github.com/pointfreeco/swift-snapshot-testing/issues/750 | |
| /// https://github.com/pointfreeco/swift-snapshot-testing/pull/757 |
Collaborator
There was a problem hiding this comment.
Please see how this looks in Xcode quick help and adjust formatting of Links: as appropriate for ideal rendering.
Contributor
Author
There was a problem hiding this comment.
Please see update. Note that I tried other ways of displaying the information so it looked polished in Quick Help, and referencing the links within a sentence worked best.
Co-authored-by: Christopher Fuller <[email protected]>
tinder-garricnahapetian
previously approved these changes
Nov 14, 2023
tinder-emanharoutunian
changed the base branch from
fix/consistent-test-implementations
to
main
tinder-emanharoutunian
dismissed
tinder-garricnahapetian’s stale review
The base branch was changed.
# Conflicts: # Tests/LayoutTests/LayoutItemTests.swift # Tests/LayoutTests/LayoutTests.swift # Tests/LayoutTests/UIView+AutoLayoutTests.swift
tinder-cfuller
approved these changes
Dec 5, 2023
tinder-garricnahapetian
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add landscape orientation tests for all safeArea and margin APIs