feat(queue): cut the queue branch on the first worker PR - #222
Merged
Conversation
Two gaps, both of which left the queue-branch mechanism unable to complete. `queue-branch.yml` is new. `work.queueBranch` only makes a drain AIM at an open `ai/queue-*`; the loop holds no write to that branch by design, so with nothing cutting one the key was inert and every worker PR fell back to `pr.base` — the mode-off path. It fires on `pull_request: [opened]`, cuts `ai/queue-<sha7>` from the integration tip on the App token (a ref created with GITHUB_TOKEN raises no `push` event, so the `open` job below would never fire), and retargets the worker PR at it. `fast-forward-queue.yml` is brought up to ADR-0010, which this repo never received: the App now opens the queue PR itself, so the maintainer is not its author and can approve it, and `pick` refuses to land anything without an approval on the current head from someone with write access. That replaces manual dispatch as the human gate — dispatch stays as a fallback. Both ADRs live in kirchDev/infrastructure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the gap that made the queue-branch mechanism unable to complete.
queue-branch.yml(new) —work.queueBranchonly makes a drain aim at an openai/queue-*; the loop holds no write to that branch by design, so with nothing cutting one the key was inert and every worker PR fell back to the integration branch. Fires onpull_request: [opened], cutsai/queue-<sha7>from the integration tip on the App token, retargets the worker PR at it.The App token is load-bearing: a ref created with
GITHUB_TOKENraises nopushevent, sofast-forward-queue.yml'sopenjob would never fire.See ADR-0012 in kirchDev/infrastructure.
fast-forward-queue.ymlis also brought up to the ADR-0010 shape this repo never received: the App opens the queue PR itself andpickrefuses to land anything without an approval on the current head. Manual dispatch stays as a fallback.