Skip to content

Make FontFamilyDropdown compatible w/ Python 3.13 #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JohnStrunk
Copy link

Several of the widgets are incompatible w/ Python 3.13 due to the use of is instead of ==. This PR fixes those instances that interfere with the usage of the FontFamilyDropdown widget.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.48%. Comparing base (ebaa7d4) to head (51694a6).

Files with missing lines Patch % Lines
ttkwidgets/font/familydropdown.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   89.53%   89.48%   -0.06%     
==========================================
  Files          43       43              
  Lines        4032     4021      -11     
==========================================
- Hits         3610     3598      -12     
- Misses        422      423       +1     
Files with missing lines Coverage Δ
ttkwidgets/font/familylistbox.py 95.65% <100.00%> (-0.19%) ⬇️
ttkwidgets/font/sizedropdown.py 94.11% <100.00%> (-0.33%) ⬇️
ttkwidgets/font/familydropdown.py 73.68% <50.00%> (-1.32%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebaa7d4...51694a6. Read the comment docs.

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant