Merge tkinterpp-notebook into tkinterpp-merger to add Notebook widget #43
Conversation
sbordeyne
changed the title
|
Largely based on your work @j4321 , but I'm also working on integrating "drag to new toplevel" functionality", as well as adding traversal with the mousewheel when hovering the tab row. |
There was a problem hiding this comment.
In addition to my comments on specific lines, there are still some issues with the style. Especially, when I execute setup_style() after creating the notebook, I get (even running directly the example without using any interactive console)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/media/DATA/Divers/ttkwidgets/ttkwidgets/notebook.py", line 388, in setup_style
style.element_create('close', 'image', "img_close",
File "/usr/lib/python3.8/tkinter/ttk.py", line 465, in element_create
self.tk.call(self._name, "element", "create", elementname, etype,
_tkinter.TclError: image "img_close" doesn't exist
Also the widget does not adapt totally to changes of theme after its creation, an feature I had not worked on in my app since the theme was chosen once and for all.
Finally, with some themes (e.g. 'clam' and 'alt') the tabs don't have visible borders. This seems to come from l. 424
style.configure('Notebook.Tab', relief='raised', borderwidth=1,
**style_config)
from the style_config, however I don't understand why since the default lightcolor and darkcolor are different. I can help you look into it.
- dropped `dont_setup_style` in favor of the Notebook._initialized class attribute - defined images now have a proper defined master - PEP8 compliance - `ba.ckground` typo fix - Removed theme change on 'Left.Notebook.TButton' and 'Right.Notebook.TButton'
|
A number of these should be fixed now |
PR Details:
Description
A Notebook widget that includes functionnality to close and reorder tabs
Checklist
/examples/testsAUTHORS.md