Fontchooser improvements #77
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An entry that takes only numbers or calculations and calculates the result of the calculation
Change the default hover-cursor from hand1 to hand2
Change the movement cursor from exchange to fleur
Change the default cursor to use the native link pointer on Mac and Windows
Add __getitem__, __setitem__, config and configure, docstring formatting
AppVeyor test failed, because I forgot to upload this
rdbende
commented
Dec 13, 2022
| @@ -49,7 +54,7 @@ def selection(self): | |||
| :return: None if no font is selected and font family name if one is selected. | |||
| :rtype: None or str | |||
| """ | |||
| if self._font.get() is "" or self._font.get() not in self._fonts: | |||
| if self._font.get() == "" or self._font.get() not in self._font_families: | |||
There was a problem hiding this comment.
The first part of this condition is useless. An empty string won't be in the font family list anyways.
sbordeyne
reviewed
Dec 19, 2022
| # --- Translation | ||
| EN = {"Font properties:": "Font properties:"} | ||
|
|
||
| FR = {"Font properties:": "Propriétés"} |
There was a problem hiding this comment.
Propriétés works, but if we were to be specific, it would be Propriétés de police d'écriture or just Propriétés de police.
It depends on the context (source : am french)
sbordeyne
reviewed
Dec 19, 2022
Comment on lines
+13
to
+20
| # --- Translation | ||
| EN = {"Font properties:": "Font properties:"} | ||
|
|
||
| FR = {"Font properties:": "Propriétés"} | ||
|
|
||
| DE = {"Font properties:": "Eigenschaften"} | ||
|
|
||
| HU = {"Font properties:": "Betűstílus"} |
There was a problem hiding this comment.
It would be good imo to create a utility class to provide translations and internationalization, so that it can be used across the entire lib, as well as be editable by the programmer.
I'll make a separate PR about this to add such a functionnality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a few little improvements for
ttkwidgets.font:FontChooserandFontSelectFrame, and all subwidgetsAutocompleteEntryListboxforFontChooserinstead of a label and a listboxFontChooserandFontSelectFrame(DE, HU, FR(just for consistency with other dialogs, I had to use DeepL for it))FontChooser: LabelFrames, preview frame redesign, dialog buttons were movedFontChooserToplevel improvements: master,.transient(),.wait_visibility(),.lift(),.grab_set()(just like inColorPicker)