Fix toolbar menu button colour #764
Open
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dark theme forces white text and button colour. I'm not sure how does it work, because I tried multiple
styles.xmlchanges (tomain_activity__main_title) including primary text, secondary text, tertiary text, button, control and foreground colours and none of them worked. Creating a separate style withandroid:tintpointed to byactionOverflowButtonStyleas suggested in some places also did not work.Since the the (forced dark) theme applies also to the pop-up appearance,
app:popupThememust be set toDayNightto respect device's light/dark mode setting.Fixes #753