Feat: Add plan option to always compare against prod #4615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
needs documentation |
Contributor
Author
Will follow up on that shortly, wanted to align on the implementation and direction before diving into it |
VaggelisD
force-pushed
the
vaggelisd/plan_compare_against_prod
branch
from
8207a2d to
b659be1
Compare
izeigerman
reviewed
Jun 2, 2025
izeigerman
reviewed
Jun 2, 2025
izeigerman
reviewed
Jun 2, 2025
VaggelisD
force-pushed
the
vaggelisd/plan_compare_against_prod
branch
from
75a357e to
7b581be
Compare
georgesittas
reviewed
Jun 3, 2025
VaggelisD
force-pushed
the
vaggelisd/plan_compare_against_prod
branch
8 times, most recently
from
80e7659 to
583da7e
Compare
georgesittas
approved these changes
Jun 4, 2025
izeigerman
reviewed
Jun 4, 2025
izeigerman
reviewed
Jun 4, 2025
VaggelisD
force-pushed
the
vaggelisd/plan_compare_against_prod
branch
2 times, most recently
from
b2eb377 to
cfc115c
Compare
izeigerman
reviewed
Jun 5, 2025
izeigerman
reviewed
Jun 5, 2025
izeigerman
reviewed
Jun 5, 2025
izeigerman
reviewed
Jun 5, 2025
VaggelisD
force-pushed
the
vaggelisd/plan_compare_against_prod
branch
from
9e0bfa9 to
06b0b53
Compare
VaggelisD
force-pushed
the
vaggelisd/plan_compare_against_prod
branch
from
06b0b53 to
fbe0543
Compare
izeigerman
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4367
This PR introduces the plan config option
always_recreate_environment; Upon enabling it, local state will always be compared against the prod (by recreating the target env), while the changes will still be committed to the target environment.