Skip to content

Conversation

@benfdking
Copy link
Contributor

@benfdking benfdking commented Jun 6, 2025

  • test e2e
  • test e2e with old version of sqlmesh in environment

@benfdking benfdking force-pushed the lsp_says_which_functions_it_exposes branch 2 times, most recently from a469ad4 to 6ee7603 Compare June 6, 2025 11:41
@benfdking benfdking requested a review from Copilot June 6, 2025 11:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds graceful handling for unsupported LSP APIs and backward compatibility with older SQLMesh versions.

  • Introduces invalid_state and sqlmesh_outdated error types and handlers in handleError.
  • Implements a sqlmesh/supported_methods endpoint plus client-side state to detect unsupported methods.
  • Updates command error messages to extract .message from error objects.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
vscode/extension/src/utilities/errors.ts Define new error interfaces and handlers (remove merge artifacts)
vscode/extension/src/lsp/lsp.ts Track supported methods state; update call_custom_method logic
vscode/extension/src/lsp/custom.ts Add SupportedMethodsMethod to CustomLSPMethods
vscode/extension/src/commands/renderModel.ts Use .message property on errors for showErrorMessage
sqlmesh/lsp/main.py Register sqlmesh/supported_methods feature in the LSP server
sqlmesh/lsp/custom.py Add Pydantic models for supported methods request/response
Comments suppressed due to low confidence (1)

vscode/extension/src/utilities/errors.ts:21

  • There are leftover merge conflict markers (<<<<<<<, =======, >>>>>>>) in this file. Please remove them to restore valid syntax.
<<<<<<< HEAD

@benfdking benfdking force-pushed the lsp_says_which_functions_it_exposes branch from 6ee7603 to 6df18fb Compare June 6, 2025 12:24
@benfdking benfdking linked an issue Jun 6, 2025 that may be closed by this pull request
@benfdking benfdking force-pushed the lsp_says_which_functions_it_exposes branch from 6df18fb to f39c420 Compare June 6, 2025 12:51
@benfdking benfdking enabled auto-merge (squash) June 6, 2025 12:52
@benfdking benfdking merged commit 321b118 into main Jun 6, 2025
25 checks passed
@benfdking benfdking deleted the lsp_says_which_functions_it_exposes branch June 6, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better Install guidance for VS Code Extension

3 participants