Chore!: bump sqlglot to v26.26.0 #4695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
commented
Jun 9, 2025
Comment on lines
-646
to
-648
| # It doesn't work the other way which is what we currently expect | ||
| with pytest.raises(ParseError): | ||
| normalize_model_name("`catalog`.`db`.`table`", default_catalog=None, dialect=None) |
Contributor
Author
There was a problem hiding this comment.
This change is due to this commit. The normalize_model_name helper relies on to_table under the hood, which is now more lenient and doesn't fail despite the presence of backticks & absence of a dialect like "bigquery".
Basically, the behavior introduced by that sqlglot change is that this table name now literally includes the backticks in the table parts.
erindru
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.