Fix: display_name should not exclude the default catalog when environment_suffix_target is set to CATALOG #4821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, when using
environment_suffix_target: catalogagainst a model in the default catalog, the CLI would give output like:This was due to an output optimisation where we hid the catalog as unnecessary information if it matched the default catalog.
However,
environment_suffix_target: catalogrelies on the default catalog being present because it needs it to generate the catalog name for the virtual environment.This PR fixes the output:
Note that this was a display-only issue, the SQL queries being executed in the background still contained the correct catalog