ci: test extension through code-server and in ci #4827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
benfdking
commented
Jun 26, 2025
benfdking
force-pushed
the
test_through_code_server_and_ci
branch
4 times, most recently
from
83fc759 to
c5778ff
Compare
Comment on lines
29
to
62
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '22' | ||
| - uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: latest | ||
| - name: Install dependencies | ||
| run: pnpm install | ||
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.12' | ||
| - name: Install python dependencies | ||
| run: | | ||
| python -m venv .venv | ||
| source .venv/bin/activate | ||
| make install-dev | ||
| - name: Install code-server | ||
| run: curl -fsSL https://code-server.dev/install.sh | sh | ||
| - name: Install Playwright browsers | ||
| working-directory: ./vscode/extension | ||
| run: pnpm exec playwright install | ||
| - name: Run e2e tests | ||
| working-directory: ./vscode/extension | ||
| run: | | ||
| source ../../.venv/bin/activate | ||
| pnpm run test:e2e tests/stop.spec.ts |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 6 months ago
To fix the issue, we need to add a permissions block to the workflow file. This block should specify the least privileges required for the workflow to function correctly. Since the workflow primarily involves reading repository contents and running tests, the contents: read permission is sufficient. This block can be added at the root level of the workflow to apply to all jobs or within each job to define job-specific permissions.
Suggested changeset
1
.github/workflows/pr.yaml
| @@ -10,2 +10,4 @@ | ||
| cancel-in-progress: true | ||
| permissions: | ||
| contents: read | ||
| jobs: |
Copilot is powered by AI and may make mistakes. Always verify output.
1 task
benfdking
force-pushed
the
test_through_code_server_and_ci
branch
2 times, most recently
from
442d063 to
95d78f7
Compare
benfdking
force-pushed
the
test_through_code_server_and_ci
branch
from
95d78f7 to
0a1455e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.