Feat: add dtntz date macro variant #4838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erindru
approved these changes
Jun 29, 2025
georgesittas
force-pushed
the
jo/add_dtntz_macro_variable
branch
from
354b6b7 to
c086ce1
Compare
georgesittas
force-pushed
the
jo/add_dtntz_macro_variable
branch
from
c086ce1 to
7333fe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue discussed in this Slack thread: https://tobiko-data.slack.com/archives/C044BRE5W4S/p1749739413928599.
The
_dtdate macro variables always inject a time zone in the resultingdatetimeobject, even if it'sUTC. This is problematic in certain cases, e.g., when these values are compared to a zone-unaware timestamps. For instance, Redshift isn't clever enough when comparing zone-aware and unaware timestamps, leading to full scans instead of pruning.The only alternative that exists today to work around this issue is to have string versions of these date values and cast them, which isn't a great experience. This PR covers this feature gap.