fix: swap truncate logic #4971
Closed
fix: swap truncate logic #4971
+101
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+14
to
+92
| runs-on: ubuntu-latest | ||
| if: github.event.pull_request.head.repo.full_name == github.repository | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.12' | ||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v6 | ||
| - name: Set up Node.js for UI build | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
| - name: Install pnpm | ||
| uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: latest | ||
| - name: Install UI dependencies | ||
| run: pnpm install | ||
| - name: Build UI | ||
| run: pnpm --prefix web/client run build | ||
| - name: Install Python dependencies | ||
| run: | | ||
| python -m venv .venv | ||
| source .venv/bin/activate | ||
| pip install build twine setuptools_scm | ||
| - name: Generate development version | ||
| id: version | ||
| run: | | ||
| source .venv/bin/activate | ||
| # Generate a development version using existing script | ||
| DEV_VERSION=$(python .github/scripts/get_scm_version.py) | ||
| echo "version=$DEV_VERSION" >> $GITHUB_OUTPUT | ||
| echo "Generated development version: $DEV_VERSION" | ||
| - name: Build package | ||
| run: | | ||
| source .venv/bin/activate | ||
| python -m build | ||
| - name: Configure PyPI for private repository | ||
| run: | | ||
| cat > ~/.pypirc << EOF | ||
| [distutils] | ||
| index-servers = tobiko-private | ||
| [tobiko-private] | ||
| repository = ${{ secrets.TOBIKO_PRIVATE_PYPI_URL }} | ||
| username = _json_key_base64 | ||
| password = ${{ secrets.TOBIKO_PRIVATE_PYPI_KEY }} | ||
| EOF | ||
| - name: Publish to private PyPI | ||
| run: | | ||
| source .venv/bin/activate | ||
| python -m twine upload -r tobiko-private dist/* | ||
| - name: Get commit information | ||
| id: commit | ||
| run: | | ||
| echo "author=$(git log -1 --format='%an')" >> $GITHUB_OUTPUT | ||
| echo "hash=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT | ||
| echo "message=$(git log -1 --format='%s')" >> $GITHUB_OUTPUT | ||
| - name: Trigger private repository workflow | ||
| uses: convictional/[email protected] | ||
| with: | ||
| owner: ${{ secrets.PRIVATE_REPO_OWNER }} | ||
| repo: ${{ secrets.PRIVATE_REPO_NAME }} | ||
| github_token: ${{ secrets.PRIVATE_REPO_TOKEN }} | ||
| workflow_file_name: ${{ secrets.PRIVATE_WORKFLOW_FILE }} | ||
| client_payload: | | ||
| { | ||
| "package_version": "${{ steps.version.outputs.version }}", | ||
| "python_version": "3.12", | ||
| "author": "${{ steps.commit.outputs.author }}", | ||
| "hash": "${{ steps.commit.outputs.hash }}", | ||
| "message": "${{ steps.commit.outputs.message }}", | ||
| "pr_number": "${{ github.event.pull_request.number }}" | ||
| } |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 6 months ago
To address the issue, we will add a permissions block at the root of the workflow file to define the least privileges required for the task. Based on the workflow's operations:
- The workflow uses
actions/checkout, which requirescontents: readto access repository files. - The workflow publishes a package using
twine, and triggers a private repository workflow, which might involve using secrets but does not require additional write permissions to repository contents.
Thus, adding permissions: contents: read at the root level is appropriate to ensure minimal permissions while allowing the workflow to function correctly.
Suggested changeset
1
.github/workflows/private-repo-test.yaml
| @@ -1,3 +1,5 @@ | ||
| permissions: | ||
| contents: read | ||
| name: Private Repo Testing | ||
|
|
||
| on: |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix from this PR: #4814