BUG: fix writing files with both int32 and int64 cols#1502
Open
m-richards wants to merge 3 commits intoToblerity:mainfrom
Open
BUG: fix writing files with both int32 and int64 cols#1502m-richards wants to merge 3 commits intoToblerity:mainfrom
m-richards wants to merge 3 commits intoToblerity:mainfrom
Conversation
m-richards
commented
Sep 4, 2025
| assert first["properties"]["foo"] == 3694063472 | ||
|
|
||
| def test_mixed_int_widths(tmpdir): | ||
| """Demonstrate fix for #1501.""" |
Author
There was a problem hiding this comment.
I wasn't really sure where to put this test. I noticed it's also a problem for shapefiles and here seemed like an okay spot, but happy to move it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt at resolving #1501.
Edit: This also seems to resolve #1490